[etcd] add 3.5.5 to all kubernetes releases

[mzaian]

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR adds etcd 3.5.5 and makes it the default for kubernetes 1.24.xx , 1.23.xx , 1.22.xx The release changelog is here https://github.com/etcd-io/etcd/blob/main/CHANGELOG/CHANGELOG-3.5.md This release addresses some major issues specially this issue https://github.com/etcd-io/etcd/pull/14424 , So this why I added it for current supported kubernetes releases in kubespray.

Does this PR introduce a user-facing change?:

[etcd] add 3.5.5

[floryut]

I'm incline to hold for 2.20 release, as I'd prefer to keep the same version as k8s core repo (3.5.4 for 1.24.x/3.5.5 for 1.25.x); WDYT ?

[oomichi]

I'm incline to hold for 2.20 release, as I'd prefer to keep the same version as k8s core repo (3.5.4 for 1.24.x/3.5.5 for 1.25.x); WDYT ?

That seems a nice idea for me. BTW where do we need to check for the etc version k8s core repo? I checked the k8s integration test script which installs etcd and the specified version is 3.5.3 in release-1.24 branch as https://github.com/kubernetes/kubernetes/blob/release-1.24/hack/lib/etcd.sh#L19

[mzaian]

I'm incline to hold for 2.20 release, as I'd prefer to keep the same version as k8s core repo (3.5.4 for 1.24.x/3.5.5 for 1.25.x); WDYT ?

That seems a nice idea for me. BTW where do we need to check for the etc version k8s core repo? I checked the k8s integration test script which installs etcd and the specified version is 3.5.3 in release-1.24 branch as https://github.com/kubernetes/kubernetes/blob/release-1.24/hack/lib/etcd.sh#L19

I believe it's here https://github.com/kubernetes/kubernetes/blob/release-1.24/build/dependencies.yaml#L58 and I agree that we can also postpone this to after the release. I think this will go ahead after this PR here: https://github.com/kubernetes/kubernetes/pull/112545

[mzaian]

I did not close this, just reverted the changes to README & roles/download/defaults/main.yml just to have the hashes only!

[floryut]

You can reopen it, github automatically close the PR if there is no change detected

[floryut]

@mzaian Can you revive this one ? otherwise I'll bump etcd if you're not available, thanks :+1:

[mzaian]

@floryut I can but it has not changed still k8s 1.25 is using etcd 3.5.4 https://github.com/kubernetes/kubernetes/blob/v1.25.3/build/dependencies.yaml#L57-L58

[floryut]

Oh my bad I saw the PR but didn't see it was still open ~~ https://github.com/kubernetes/kubernetes/pull/113197

[mzaian]

Subscribed, Once it's done. I will revive this PR.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mzaian Once this PR has been reviewed and has the lgtm label, please assign mattymo for approval by writing /assign @mattymo in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mzaian Once this PR has been reviewed and has the lgtm label, please assign mattymo for approval by writing /assign @mattymo in a comment. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[mzaian]

@floryut Here: https://github.com/kubernetes-sigs/kubespray/pull/9419