Argo CD : checksum support for the install url

[voondo]

What type of PR is this? /kind bug

What this PR does / why we need it: It allows the argocd deployment which was broken.

Which issue(s) this PR fixes: Fixes #12223

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Add argocd_install_checksum: str, to define the checksum of `argocd_install_url`

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: voondo / name: Romain Lalaut (149e20d18ba1979a3c3c795a535a6d9a4eb2d170)

[k8s-ci-robot]

Welcome @voondo!

It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @voondo. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

[ErikJiang]

I noticed that there are no tests related to enabling ArgoCD in tests/files. Would you like to add some?

[yankay]

/ok-to-test

[tico88612]

At most, it can be related #12223, but not fixed. Because there is still no checksum here.

[voondo]

@tico88612 is it better now ?

@ErikJiang I'm not sure how to add a test for that. Add a file like this ?

# tests/files/debian12-argocd.yml
cloud_image: debian-12
argocd_enabled: true

[tico88612]

@voondo NACK. You should add the checksum in roles/kubespray-defaults/defaults/main/checksums.yml, and add the download information in roles/kubespray-defaults/defaults/main/download.yml

FYI: #11763

[voondo]

@tico88612 done

[ErikJiang]

@voondo I don't think we need to add a new file for this. We could simply add argocd_enabled: true to the existing test file at: https://github.com/kubernetes-sigs/kubespray/blob/master/tests/files/debian12-cilium.yml

@tico88612 What do you think?

[VannTen]

/lgtm /approve

Thanks for the work ! Adding argocd to component_hash_update would be a welcome follow-up.

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: VannTen, voondo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• ~~OWNERS~~ [VannTen]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[tico88612]

/cherry-pick release-2.28

[k8s-infra-cherrypick-robot]

@tico88612: new pull request created: #12467

In response to this:

/cherry-pick release-2.28

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.