kubespray icon indicating copy to clipboard operation
kubespray copied to clipboard

Cleanup: remove in-tree cloud provider support

Open tico88612 opened this issue 1 year ago • 2 comments

What type of PR is this?

/kind cleanup /kind documentation

What this PR does / why we need it:

Kubernetes v1.31 remove in-tree cloud provider related code, we should remove related support.

Which issue(s) this PR fixes:

Fixes #10495

Special notes for your reviewer:

Waiting for #11378 get merge.

Does this PR introduce a user-facing change?:

[action required] no longer support in-tree cloud provider, please delete or write `external` to the `cloud_provider` variable.

tico88612 avatar Oct 15 '24 01:10 tico88612

Skipping CI for Draft Pull Request. If you want CI signal for your change, please convert it to an actual PR. You can still manually trigger a test run with /test all

k8s-ci-robot avatar Oct 15 '24 01:10 k8s-ci-robot

I don't actually think we need to wait for #11378 : since kubernetes v1.31 does not support in-tree provider, even if kubespray has support, it won't work. So let's proceed with the removal :+1:

VannTen avatar Oct 31 '24 10:10 VannTen

/label tide/merge-method-merge /ok-to-test

tico88612 avatar Nov 04 '24 16:11 tico88612

/approve Thanks for the work !

VannTen avatar Nov 05 '24 09:11 VannTen

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, tico88612, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Nov 05 '24 09:11 k8s-ci-robot