kubespray
kubespray copied to clipboard
The control plane pre-update only implemented for docker
I was reading through the whole kubespray and noticed this inconsistency: other container runtimes can potentially be used, but forceful deletion is only implemented for docker.
https://github.com/kubernetes-sigs/kubespray/blob/24dc4cef56848c2efc3a9e050959f4feee92976a/roles/kubernetes/control-plane/tasks/pre-upgrade.yml#L1-L21
Is this an overlook, or is there a reason why this is done this way?
Looks like a bug to me, as it is not checked whether docker is even used at all.
Possible fixes:
- Use
crictl
there to abstract around the runtime? - Run commands with
nerdctl
for containerd too? - ?