kubespray icon indicating copy to clipboard operation
kubespray copied to clipboard

[etcd/tracing]: fix etcd sampling rate flag

Open ugur99 opened this issue 9 months ago • 4 comments

What type of PR is this? /kind bug

What this PR does / why we need it: This MR fixes wrong env variable for etcd.

Which issue(s) this PR fixes:

Fixes # none

Special notes for your reviewer: etcd monitoring document

Does this PR introduce a user-facing change?:

[etcd] fixes wrong distributed tracing flag for etcd 

ugur99 avatar May 07 '24 17:05 ugur99

Hi @ugur99. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 07 '24 17:05 k8s-ci-robot

Hi @mzaian and @yankay! Sorry for tagging you here, but I just realized that I made a typo in one of the etcd tracing flags. This MR fixes the problem. I thought it would be nice if we could merge and include this for the next release.

ugur99 avatar May 07 '24 17:05 ugur99

Hi @mzaian and @yankay! Sorry for tagging you here, but I just realized that I made a typo in one of the etcd tracing flags. This MR fixes the problem. I thought it would be nice if we could merge and include this for the next release.

Thanks for catching this @ugur99

/ok-to-test

mzaian avatar May 07 '24 17:05 mzaian

Hi @mzaian! anything you want me to work on regarding this PR?

ugur99 avatar May 12 '24 20:05 ugur99

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mzaian, ugur99

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 13 '24 10:05 k8s-ci-robot