kubespray icon indicating copy to clipboard operation
kubespray copied to clipboard

Update external huawei cloud controller to 0.26.8

Open dibi-codes opened this issue 9 months ago • 4 comments

What type of PR is this?

/kind feature

What this PR does / why we need it:

Update the default version of the external huawei cloud controller to 0.26.8

Special notes for your reviewer:

See: https://github.com/kubernetes-sigs/cloud-provider-huaweicloud/compare/v0.26.6...v0.26.8

Does this PR introduce a user-facing change?:

Update external huawei cloud controller to 0.26.8

dibi-codes avatar May 07 '24 13:05 dibi-codes

Hi @dabeck. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar May 07 '24 13:05 k8s-ci-robot

Hello @dabeck

Thanks for the PR. I did not check but did you check to sync https://github.com/kubernetes-sigs/cloud-provider-huaweicloud/blob/v0.26.8/manifests/huawei-cloud-controller-manager-daemonset.yaml with https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubernetes-apps/external_cloud_controller/huaweicloud/templates/external-huawei-cloud-controller-manager-ds.yml.j2

mzaian avatar May 07 '24 15:05 mzaian

Hello @dabeck

Thanks for the PR. I did not check but did you check to sync https://github.com/kubernetes-sigs/cloud-provider-huaweicloud/blob/v0.26.8/manifests/huawei-cloud-controller-manager-daemonset.yaml with https://github.com/kubernetes-sigs/kubespray/blob/master/roles/kubernetes-apps/external_cloud_controller/huaweicloud/templates/external-huawei-cloud-controller-manager-ds.yml.j2

Good catch - I'll have a look and let you know/update the PR

dibi-codes avatar May 07 '24 15:05 dibi-codes

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dabeck, MrFreezeex, mzaian

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 08 '24 08:05 k8s-ci-robot