kubespray icon indicating copy to clipboard operation
kubespray copied to clipboard

Avoid potential loop_var shadowing

Open VannTen opened this issue 9 months ago • 1 comments

What type of PR is this? /kind cleanup

What this PR does / why we need it: With CentOS, kubespray currently produces the following warning:

[WARNING]: TASK: bootstrap-os : Enable Oracle Linux repo: The loop variable
'item' is already in use. You should set the `loop_var` value in the
`loop_control` option for the task to something else to avoid variable
collisions and unexpected behavior.

This could bites us in nasty ways, so fix it.

Does this PR introduce a user-facing change?:

NONE

VannTen avatar May 03 '24 14:05 VannTen

/assign @mzaian

Re-testing email reply.

VannTen avatar May 13 '24 07:05 VannTen

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: MrFreezeex, mzaian, VannTen

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 13 '24 10:05 k8s-ci-robot