kubespray icon indicating copy to clipboard operation
kubespray copied to clipboard

Fixed some urls in offline.yml file that wasn't yml formatted

Open GmrezaH opened this issue 1 year ago • 4 comments

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change

/kind bug

/kind cleanup /kind design /kind documentation /kind failing-test /kind feature /kind flake

What this PR does / why we need it: It fixes a bug in the inventory/sample/group_vars/all/offline.yml file Which issue(s) this PR fixes: Some urls in offline.yml file were not YAML formatted (they had "=" instead of ":")

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?: NONE


GmrezaH avatar Apr 26 '24 12:04 GmrezaH

Hi @GmrezaH. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 26 '24 12:04 k8s-ci-robot

/ok-to-test

yankay avatar Apr 29 '24 04:04 yankay

Thanks @GmrezaH /approve

yankay avatar May 06 '24 02:05 yankay

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: GmrezaH, yankay

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 06 '24 02:05 k8s-ci-robot

Thanks @GmrezaH

/lgtm

ErikJiang avatar May 08 '24 09:05 ErikJiang