kubespray icon indicating copy to clipboard operation
kubespray copied to clipboard

add host-based calculation for kube cpu/memory reserved resources

Open Payback159 opened this issue 1 year ago • 11 comments

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespaces from that line:

/kind api-change /kind bug /kind cleanup /kind design /kind documentation /kind failing-test

/kind feature

/kind flake

What this PR does / why we need it:

Reserving resources helps to improve the stability of the cluster components. In my opinion, the resource consumption of the kbelet also changes with the load of the node (Scheduled Pods), so there should also be a possibility to reserve the system resources relative to the node size.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Follow up PR for #10830

Does this PR introduce a user-facing change?:

enable kube_enable_auto_reserved_resources to allow kubespray to calculate kubeReserved values for cpu and memory based on host-size (default disabled)

Payback159 avatar Apr 12 '24 20:04 Payback159

Hi @Payback159. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 12 '24 20:04 k8s-ci-robot

/ok-to-test

yankay avatar Apr 14 '24 03:04 yankay

Hello @yankay, Hello @mzaian,

I have fixed the variable problem and CI seems to be fine now. May I ask you for a review, maybe the PR will even make it into the v2.25.0 release?

thank you and kind regards! :-)

Payback159 avatar Apr 26 '24 18:04 Payback159

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: Payback159 / name: Alexander (fd1ae56defde0828bf8f45e49e8edf846ffa308b)

Hello,

I wanted to drop by here again. Do you have anything against including the PR? 😊

I think it's too late for v2.25 but maybe the PR will make it into the next release. 😁

Payback159 avatar Jun 17 '24 15:06 Payback159

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Payback159 Once this PR has been reviewed and has the lgtm label, please assign vannten for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 29 '24 14:08 k8s-ci-robot

You're referring to the removed "master" variant on the new docs, otherwise this looks ok

VannTen avatar Oct 02 '24 22:10 VannTen