kubespray icon indicating copy to clipboard operation
kubespray copied to clipboard

Delegate prep_kubeadm_images to control plane

Open VannTen opened this issue 1 year ago • 7 comments

What type of PR is this? /kind bug

What this PR does / why we need it: Doing this instead of checking for host membership prevent breaking for cases where we don't run on control plane (--limit for instance, when scaling). import_tasks is more approriate, since the tasks are not dynamic and we always run them (mostly).

Which issue(s) this PR fixes: Fixes #10912

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Establishing the list of kubeadm images is always delegated to first control plane node, preventing failure with --limit usages

VannTen avatar Feb 24 '24 22:02 VannTen

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MrFreezeex, VannTen Once this PR has been reviewed and has the lgtm label, please assign cristicalin for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 26 '24 16:02 k8s-ci-robot

delegate_to mess up with the "Copy binary to system path for kubeadm" ... I'm gonna try to take that opportunity to refactor the download role a bit (read: a lot) to fix this properly, but it's gonna take a little while.

VannTen avatar Feb 27 '24 08:02 VannTen

😁 Hello @VannTen, the functionality to scale nodes is currently unavailable due to the kubeadm_images_raw is undefined issue. Do you know if there is any latest progress on fixing this problem?

ErikJiang avatar Apr 10 '24 06:04 ErikJiang

I'm focusing on the DNS issue (after I'm back from vacation), this is the next item on my to-do list. Proper fix needs some refactor of the download role, mainly separating download from binaries and containers if I recall correctly.

VannTen avatar Apr 17 '24 12:04 VannTen

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Apr 30 '24 02:04 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 29 '24 03:07 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Aug 28 '24 03:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Sep 27 '24 04:09 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Sep 27 '24 04:09 k8s-ci-robot