kubespray
kubespray copied to clipboard
kubernetes-sigs
add cilium hubble-ui enable flag
What type of PR is this?
Uncomment only one
/kind <>line, hit enter to put that in a new line, and remove leading whitespaces from that line:/kind api-change /kind bug /kind cleanup /kind design /kind documentation /kind failing-test /kind feature /kind flake
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #10938
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
allow disabling cilium hubble-ui using `cilium_enable_hubble_ui` variable
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: pedro-peter / name: peterw (81be394dec54ecdba5fe037790768f50b0005973, bfac7d8b3ed142b54e054f53a317ec4ecd7f3922, 1e7df3208726ab2313ec9d016c1f323c1edfe425)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @pedro-peter. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
- ❌ login: @pedromcpedro / The commit (7fe6747). This user is authorized, but they must confirm their affiliation with their company. Start the authorization process by clicking here, click "Corporate", select the appropriate company from the list, then confirm your affiliation on the page that appears. For further assistance with EasyCLA, please submit a support request ticket.
Is it not possible to contribue to the kubespray project as in individual contributor any more?
AFAIK it's totally possible, there is two possible CLA , the Individual and the Corporate one. Not sure how exactly the bot works though, maybe ask on contrib exp slack ?
@cyclinder I needed to switch email addresses in the commit. should be good now, thanks.
@VannTen @cyclinder similar to the request in (https://github.com/kubernetes-sigs/kubespray/pull/10943)
I've also updated this file: https://github.com/kubernetes-sigs/kubespray/pull/10939/files#diff-62196bb4551c31e1247185a8b95b8cd02f985b708bff4422f5485c2ad8bdaf39R144
did a rebase from the master branch. looks like it needs lgtm label again...
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: cyclinder, pedro-peter Once this PR has been reviewed and has the lgtm label, please ask for approval from yankay. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
