kubespray icon indicating copy to clipboard operation
kubespray copied to clipboard

Merge stops and removes systemd services tasks in reset playbook

Open kimsehwan96 opened this issue 1 year ago • 3 comments

What type of PR is this?

/kind design

What this PR does / why we need it:

This PR merges tasks stop and remove systemd services related with etcd (etcd.service, etcd-events.service).

There is no systemd daemon-reload tasks after stop and remove systemd services about etcd, so if you run command $ systemctl status etcd on etcd node after all reset tasks are done then output will be shown which indicate etcd systemd is stopped(inactivated).

It may feel confusing about the systemd services are really removed or not.

I think it's better apply this changes if there is no specific reason to seperate this tasks.

By the way, There are crio , containerd tags in - name: Reset | remove services task and I relocated the etcd.service, etcd-events.service systemd services with_items so I'm worried about it may cause some break in some specific reset usecases

Which issue(s) this PR fixes:

Fixes #10901

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

Merge stop and remove systemd service task in reset/tasks/main.yml

kimsehwan96 avatar Feb 08 '24 05:02 kimsehwan96

Hi @kimsehwan96. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 08 '24 05:02 k8s-ci-robot

/ok-to-test

yankay avatar Feb 18 '24 03:02 yankay

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: floryut, kimsehwan96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 19 '24 10:02 k8s-ci-robot

/lgtm

VannTen avatar May 03 '24 09:05 VannTen