kubespray
kubespray copied to clipboard
Merge stops and removes systemd services tasks in reset playbook
What type of PR is this?
/kind design
What this PR does / why we need it:
This PR merges tasks stop and remove systemd services related with etcd (etcd.service, etcd-events.service).
There is no systemd daemon-reload tasks after stop and remove systemd services about etcd, so if you run command $ systemctl status etcd
on etcd node after all reset tasks are done then output will be shown which indicate etcd systemd is stopped(inactivated).
It may feel confusing about the systemd services are really removed or not.
I think it's better apply this changes if there is no specific reason to seperate this tasks.
By the way, There are crio
, containerd
tags in - name: Reset | remove services
task and I relocated the etcd.service
, etcd-events.service
systemd services with_items
so I'm worried about it may cause some break in some specific reset usecases
Which issue(s) this PR fixes:
Fixes #10901
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Merge stop and remove systemd service task in reset/tasks/main.yml
Hi @kimsehwan96. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test
on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test
label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
/ok-to-test
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: floryut, kimsehwan96
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [floryut]
Approvers can indicate their approval by writing /approve
in a comment
Approvers can cancel approval by writing /approve cancel
in a comment
/lgtm