kubespray
kubespray copied to clipboard
Merge stop and remove systemd service task in`reset/tasks/main.yml`
What would you like to be added
There are stop and remove systemd service tasks in reset/tasks/main.yml
(https://github.com/kubernetes-sigs/kubespray/blob/ad565ad9225c7b2fde6188d600eff71249752007/roles/reset/tasks/main.yml#L2-L31)
By the way, the tasks that stop and remove etcd.service and etcd-events.service are in other tasks (https://github.com/kubernetes-sigs/kubespray/blob/ad565ad9225c7b2fde6188d600eff71249752007/roles/reset/tasks/main.yml#L137-L157)
And then, there is no systemd daemon-reload
tasks after stop and remove etcd related systemd services, so if you run systemctl status etcd.service
then the output shows inactivate
etcd related services.
So I think it's better that merging the tasks stop and remove etcd.service, etcd-events.service.
Why is this needed
I think its better that merging the tasks that stop and remove systemd services because if do not, you can get some outputs from $ systemctl status etcd
on etcd node after all reset tasks are done. and it may feel confusing about the systemd services are really removed or not.