kubespray
kubespray copied to clipboard
Wrong tag in README.md (2.23)
What happened?
I tried to update kubespray to v2.23.2 and downloaded https://github.com/kubernetes-sigs/kubespray/archive/refs/tags/v2.23.2.tar.gz
And I found that README.md
file in v.2.23.2 tag is for old version 2.22.1, for example:
git checkout v2.22.1
docker pull quay.io/kubespray/kubespray:v2.22.1
...
In branch https://github.com/kubernetes-sigs/kubespray/blob/release-2.23/README.md
git checkout v2.23.2
docker pull quay.io/kubespray/kubespray:v2.23.2
What did you expect to happen?
Something wrong in your ci files
How can we reproduce it (as minimally and precisely as possible)?
Open link:
https://github.com/kubernetes-sigs/kubespray/blob/release-2.23/README.md
and scroll, you will see git checkout v2.23.2
Open link:
https://github.com/kubernetes-sigs/kubespray/blob/v2.23.2/README.md
and you will see git checkout v2.22.1
Or you can git diff branch release-2.23 and tag v2.23.2:
git diff release-2.23..v2.23.2
OS
Oracle Linux Server release 8.9
Version of Ansible
ansible [core 2.14.11]
Version of Python
Python 3.11.5
Version of Kubespray (commit)
no git folder, your archive
Network plugin used
cilium
Full inventory with variables
No response
Command used to invoke ansible
No response
Output of ansible run
No response
Anything else we need to know
No response
@yankay
Thanks @anutator @VannTen
I think it's a bug of https://github.com/kubernetes-sigs/kubespray/blob/master/RELEASE.md.
If we add
Check the README.md to ensure the kubespray version is the same as the version that will be released.
Just before the “new release in GitHub” can fix it.
/retitle Wrong tag in README.md (2.23) /remove-kind bug /kind documentation
The Kubernetes project currently lacks enough contributors to adequately respond to all issues.
This bot triages un-triaged issues according to the following rules:
- After 90d of inactivity,
lifecycle/stale
is applied - After 30d of inactivity since
lifecycle/stale
was applied,lifecycle/rotten
is applied - After 30d of inactivity since
lifecycle/rotten
was applied, the issue is closed
You can:
- Mark this issue as fresh with
/remove-lifecycle stale
- Close this issue with
/close
- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
Hey @yankay, Is this issue still up for grabs?
Thank you
Hey @yankay, Is this issue still up for grabs?
Thank you
I think it has been fixed. The https://github.com/kubernetes-sigs/kubespray/tree/v2.24.1 is correct.