kubespray
kubespray copied to clipboard
kubernetes-sigs
Adjust to ansible galaxy
What type of PR is this?
Uncomment only one
/kind <>line, hit enter to put that in a new line, and remove leading whitespaces from that line:/kind api-change /kind bug
/kind cleanup
/kind design /kind documentation /kind failing-test /kind feature /kind flake
What this PR does / why we need it: Adjust to ansible galaxy standards Which issue(s) this PR fixes:
Fixes #10248
Special notes for your reviewer:
Does this PR introduce a user-facing change?:
Adjust to ansible galaxy (⚠️ roles name changed!)
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: maciej-markowski (da22fa0179a00185011e17690777281afdb0546b, 8ba24d164b3b28cfe45e897358c027cadebaf5c9, 57352322076653154be3ea2a44c75935cbd6e93a, f6391f3eae6f5d5694c24a4773012db53f5a481d, ba8cbbecc82fd2ff1b544f4e3353893f8ed45e63, f3a9f08332434e8e93c6aef65358762e4d72d4d7, cda043abe5a227e29bcc459b40d1bd1336ca75bf)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Welcome @maciej-markowski!
It looks like this is your first PR to kubernetes-sigs/kubespray 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/kubespray has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @maciej-markowski. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Hiii @maciej-markowski, wow thanks for this big PR. It mostly looks good but could you separate this into two PR, like the role renaming in something separate from the rest? It would probably be easier to merge like that :pray:
Also now that we have a recent enough version in ansible-lint you can check what is not standard by removing this line https://github.com/kubernetes-sigs/kubespray/blob/master/.ansible-lint#L63
FYI I sent a small PR that targets only the error reported in the galaxy rules in ansible-lint: https://github.com/kubernetes-sigs/kubespray/pull/10277. But your PR contains a lot more changes so if you are still interested in updating it we could still go forward with the rest of the changes!
@MrFreezeex I have rebased my changes and done some more linting adjustments. It's ready for review.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: maciej-markowski, MrFreezeex Once this PR has been reviewed and has the lgtm label, please assign luckysb for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
We can do it in another PR if you prefer or add it here as you wish 🤷♂️
I would prefer to do it separately.
/assign @LuckySB
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
@LuckySB , are we going to consider ever merging this PR? I understand that there are a lot of changes but, if we keep going merging other PRs, this will constantly be flagged as needs rebase.
Given the width of changes, you might have a better luck getting this merged by splitting it up in smaller PRs (one per role, for example). Obviously it's not super fun, but at least you won't have a merge conflict on the whole PR every time another PR is merged.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle rotten - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle rotten
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Reopen this PR with
/reopen - Mark this PR as fresh with
/remove-lifecycle rotten - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
@k8s-triage-robot: Closed this PR.
In response to this:
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied- After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied- After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closedYou can:
- Reopen this PR with
/reopen- Mark this PR as fresh with
/remove-lifecycle rotten- Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/close
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.