kubebuilder
kubebuilder copied to clipboard
kubernetes-sigs
✨ feat(makefile): add setup test e2e targets
Currently, the test-e2e target in the Kubebuilder Makefile template hardcodes a single workflow: setup the Kind cluster and immediately run the end-to-end tests. This prevents projects from injecting any preparatory steps - such as installing CRDs, operators, or other third-party dependencies - before executing the actual tests.
By introducing the SETUP_TEST_E2E_TARGETS variable, users gain the flexibility to define and run one or more prerequisite targets prior to cluster setup and test execution. This change:
- Enhances extensibility: Teams can now tailor the e2e pipeline to their specific needs without forking or patching the upstream Makefile.
- Maintains backward compatibility: The default behavior remains unchanged when SETUP_TEST_E2E_TARGETS is unset, ensuring existing projects continue to work seamlessly.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: kersten Once this PR has been reviewed and has the lgtm label, please assign camilamacedo86 for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @kersten. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Hi @kersten
Thank you a lot not only for this one but for the many contributions made 🎉 Due to the reasons described in https://github.com/kubernetes-sigs/kubebuilder/pull/4876/files#r2156536612, I am closing this one as deferred. However, if you believe we should move forward and disagree, please feel free to reopen.
