kubebuilder icon indicating copy to clipboard operation
kubebuilder copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

(book) Cronjob mixup of versions in conversion webhook implementation

Open benoitgravitee opened this issue 8 months ago • 7 comments
trafficstars

What broke? What's expected?

The example of the v2 webhook (defaults/validation) is using v1 as implementation, instead of v2

https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/book/src/multiversion-tutorial/testdata/project/internal/webhook/v2/cronjob_webhook.go

Seen in: https://book.kubebuilder.io/multiversion-tutorial/webhooks

Reproducing this issue

No response

KubeBuilder (CLI) Version

n/a

PROJECT version

No response

Plugin versions

Other versions

No response

Extra Labels

No response

benoitgravitee avatar Mar 17 '25 08:03 benoitgravitee

/assign

chethanm99 avatar Mar 17 '25 08:03 chethanm99

Thank you for bringing this up.

We need to verify the reported issue and confirm the issue. After confirmed, the necessary changes should be made in the following repository: https://github.com/kubernetes-sigs/kubebuilder/tree/master/hack/docs

Since all samples used in the documentation are automatically generated when running make generate (which invokes make generate-docs), we must ensure that any custom code additions are correctly incorporated.

Let me know if you have any questions!

camilamacedo86 avatar Mar 17 '25 12:03 camilamacedo86

Hi, @camilamacedo86 I am unassigning from this issue due to old commits in the same branch through which I created the PR which may lead to confusion let others try working on it and I will try working on it using a separate branch. Thank you for your time

chethanm99 avatar Mar 17 '25 12:03 chethanm99

/unassign

chethanm99 avatar Mar 17 '25 12:03 chethanm99

Hello @chethanm99, do you still want to work on it?

damsien avatar Apr 21 '25 15:04 damsien

@damsien you can go ahead and work on this issue 👍

chethanm99 avatar Apr 21 '25 15:04 chethanm99

@chethanm99 thanks

/assign

damsien avatar Apr 21 '25 15:04 damsien

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jul 20 '25 16:07 k8s-triage-robot

/remove-lifecycle stale

camilamacedo86 avatar Jul 20 '25 17:07 camilamacedo86