kubebuilder icon indicating copy to clipboard operation
kubebuilder copied to clipboard

:bug: fix: Clean up around make lint command

Open mateusoliveira43 opened this issue 1 year ago • 3 comments
trafficstars

Why the changes were made

Fix command documentation and remove unnecessary code.

How the changes were made

When make lint command was added (https://github.com/kubernetes-sigs/kubebuilder/commit/46ea676fc75e7a8844bbf237cf8e1c4b66b24dd4#diff-e5d6d4f9d67174f1f3764674eb786688353c77cef8514e24d1323e55e5a4a7e8) I believe its documentation was copied from project Makefile (https://github.com/kubernetes-sigs/kubebuilder/commit/feb0c5463bb51d07dc9027a139a0c0a0cfc2253f#diff-76ed074a9305c04054cdebb9e9aad2d818052b07091de1f20cad0bbac34ffb52) which does run yamllint, but not command generated by kubebuilder. So, removed that part from command doc.

Since generated .golangci.yml already has gofmt and govet enabled, there is no need for fmt and vet commands (make lint and make lint-fix do that and more). Since generate script needs refactor to prior to removing fmt command, just removed vet from Makefile in this PR.

After applying changes, ran make generate.

How to test the changes made

Confirm the changes do not break any use case.

mateusoliveira43 avatar Mar 08 '24 21:03 mateusoliveira43

Hi @mateusoliveira43. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 08 '24 21:03 k8s-ci-robot

@mateusoliveira43 your PR contains unformatted source code. Are you sure your suggestion for delete fmt job is correct?

lukas016 avatar Mar 09 '24 21:03 lukas016

@camilamacedo86 can you take a look?

mateusoliveira43 avatar May 17 '24 19:05 mateusoliveira43

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, lukas016, mateusoliveira43

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar May 17 '24 21:05 k8s-ci-robot

/ok-to-test

camilamacedo86 avatar May 17 '24 21:05 camilamacedo86