kubebuilder
kubebuilder copied to clipboard
kubernetes-sigs
:bug: fix: Remove empty line at beginning of generated files
Why the changes were made
Noticed that after generating project with kubebuilder, some files had an empty line in their first line. This PR fixes this.
How the changes were made
Tried to find all files templates that started with an empty line in pkg/plugins/golang/v4/scaffolds/internal/templates folder. Removed it from them and ran make generate.
How to test the changes made
Confirm the changes do not break any use case.
Hi @mateusoliveira43. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: camilamacedo86, lukas016, mateusoliveira43
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [camilamacedo86]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
The legacy test was removed so, in order of not need to ask extra effort from the author I am forcing the merge which seems very safe in this case scenario.
