kubebuilder icon indicating copy to clipboard operation
kubebuilder copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Docs about webhook is out of date

Open Duncan-tree-zhou opened this issue 2 years ago • 11 comments
trafficstars

What broke? What's expected?

in doc file: 《Deploying Admission Webhooks》

line #38 and line #44, the include files is no longer exists.

{{#include ./testdata/project/config/default/kustomization.yaml}}

{{#include ./testdata/project/config/crd/kustomization.yaml}}

Reproducing this issue

goto 《Deploying Admission Webhooks》

KubeBuilder (CLI) Version

master

PROJECT version

master

Plugin versions

No response

Other versions

No response

Extra Labels

No response

Duncan-tree-zhou avatar Dec 23 '22 07:12 Duncan-tree-zhou

Hi @Duncan-tree-zhou,

Definitely, we should link. We should to do as it is done for v2 : https://book-v2.book.kubebuilder.io/ To achieve this goal, the PR change needs to be against book-v1 branch . Would you like to collab with this one?

camilamacedo86 avatar Jan 14 '23 11:01 camilamacedo86

@camilamacedo86 I would like to collab and make some valuable contributions.

impact-maker avatar Jan 14 '23 11:01 impact-maker

Hi @impact-maker

In this case you need to push a PR against the book-v1 branch with the same content. If you have doubts please feel free to reach out in the channel.

camilamacedo86 avatar Jan 14 '23 15:01 camilamacedo86

Hi @camilamacedo86 Added the PR #3159 Kindly review it and let me know if any changes are required on my end.

impact-maker avatar Jan 14 '23 23:01 impact-maker

@camilamacedo86 I would like to work on this Please consider

ashutosh887 avatar Feb 25 '23 18:02 ashutosh887

@camilamacedo86 Should I start working if the above PR is not approved?

ashutosh887 avatar Mar 13 '23 05:03 ashutosh887

@ashutosh887 you can see the PR #3159, it's already closed.

Duncan-tree-zhou avatar Mar 13 '23 06:03 Duncan-tree-zhou

The issue is still open @Duncan-tree-zhou I would like to work

ashutosh887 avatar Mar 13 '23 06:03 ashutosh887

Hi @Duncan-tree-zhou,

@ashutosh887 you can see the PR https://github.com/kubernetes-sigs/kubebuilder/pull/3159, it's already closed.

The PR was not accepted because it was against the v1 docs, which is legacy.

If @impact-maker will not work on this one (which seems not like) then, @ashutosh887 please feel free to work on this one.

camilamacedo86 avatar Mar 13 '23 07:03 camilamacedo86

Thanks let me try /assign

ashutosh887 avatar Mar 16 '23 16:03 ashutosh887

hello @ashutosh887 are you still working on this. If yes link the pr. I want to review the content. if not, I am interested in working on this issue. Thank you.

Sajiyah-Salat avatar Apr 29 '23 02:04 Sajiyah-Salat

A lot of changes has been introduced regards webhooks in controller-runtime Therefore, we need to remove the deprecations and follow up of them. In this way, I am closing this one in favor of: https://github.com/kubernetes-sigs/kubebuilder/issues/3721

camilamacedo86 avatar Apr 27 '24 06:04 camilamacedo86