kubebuilder icon indicating copy to clipboard operation
kubebuilder copied to clipboard

:sparkles: Update `make build` cmd with manifests generation

Open astraw99 opened this issue 3 years ago • 2 comments
trafficstars

Fixes #3016 In the doc of xxx_types.go, the comment said:

Important: Run "make" to regenerate code after modifying this file

But after the spec and status struct modified, run make did not generate manifests fields.

So this PR update make (default to make build) with manifests generation. Plugins go/v3 and go/v4-alpha are updated.

astraw99 avatar Oct 16 '22 12:10 astraw99

Hi @astraw99. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 16 '22 12:10 k8s-ci-robot

/ok-to-test /approved

camilamacedo86 avatar Oct 17 '22 10:10 camilamacedo86

@camilamacedo86 Could you please add a /lgtm label to push it to merge, thanks.

astraw99 avatar Oct 17 '22 13:10 astraw99

Hi @astraw99,

@camilamacedo86 Could you please add a /lgtm label to push it to merge, thanks.

It would be nice to get done for another maintainer. So, let's waiting for someone to have time to do a second review here.

camilamacedo86 avatar Oct 17 '22 15:10 camilamacedo86

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: astraw99, camilamacedo86

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Oct 22 '22 07:10 k8s-ci-robot