kubebuilder icon indicating copy to clipboard operation
kubebuilder copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

⚠️ migrate kubebuilder and scaffolding to ginkgo/v2

Open jakobmoellerdev opened this issue 3 years ago • 4 comments
trafficstars

This PR makes sure to migrate kubebuilder and the corresponding scaffolding to gingko/v2. Currently the entire test suite of kubebuilder itself is migrated, however there are 2 things missing:

  • [ ] Scaffolding needs to be updated (see https://github.com/kubernetes-sigs/kubebuilder/blob/master/pkg/plugins/golang/v3/scaffolds/internal/templates/controllers/controller_suitetest.go#L134) but its a breaking change and needs to go into v4-alpha scaffolding which does not yet exist
  • [ ] gingko CLI is recommended as test execution tool (especially for parallel suites) and we would have to adjust Makefiles for that, I want to take this opportunity and ask what our POV on switching from go test is

Fixes https://github.com/kubernetes-sigs/kubebuilder/pull/2875

jakobmoellerdev avatar Aug 15 '22 12:08 jakobmoellerdev

Hi @jakobmoellersap. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Aug 15 '22 12:08 k8s-ci-robot

Just saw that there is a previous pull for this in https://github.com/kubernetes-sigs/kubebuilder/pull/2522 that got closed. Also leaving this in draft until we have dedicated v4 scaffolding

jakobmoellerdev avatar Aug 16 '22 08:08 jakobmoellerdev

/ok-to-test

camilamacedo86 avatar Aug 16 '22 08:08 camilamacedo86

I would suggest to even open up this PR normally (to upgrade kubebuilder and its test) and then a follow-up PR for the scaffolding. That would make it a bit easier to maintain / review / plan. WDYT @camilamacedo86 ?

jakobmoellerdev avatar Aug 17 '22 08:08 jakobmoellerdev

Hi @jakobmoellersap that is fine, you can work on this as normal PR. No problem at all.

we can also:

/ok-to-test

/test-all

camilamacedo86 avatar Aug 23 '22 19:08 camilamacedo86

/retest

jakobmoellerdev avatar Aug 30 '22 05:08 jakobmoellerdev

/test pull-kubebuilder-e2e-k8s-1-19-16

jakobmoellerdev avatar Aug 30 '22 06:08 jakobmoellerdev

/cc @camilamacedo86

jakobmoellerdev avatar Aug 31 '22 16:08 jakobmoellerdev

I will pick up the ginkgo v2 scaffolding migration next

jakobmoellerdev avatar Sep 01 '22 13:09 jakobmoellerdev

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, jakobmoellersap, varshaprasad96

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 02 '22 16:09 k8s-ci-robot

/lgtm

Receive 2 approvals

camilamacedo86 avatar Sep 02 '22 16:09 camilamacedo86