kubebuilder
kubebuilder copied to clipboard
kubernetes-sigs
:bug: "Application Support" whitespace for mac plugins
This mini-PR simply fixes the Plugins Root Directory for darwin hosts for external Plugins.
Without this change the Plugin Discovery will always look in a non-existing Library Directory, causing the Lookup to permanently fail. A suggestion here would be to introduce the "Lookup Plugins" command that was discussed previously in the Discussion around https://github.com/kubernetes-sigs/kubebuilder/issues/2600 to also make this debuggable without having to change log messages or introducing a cli debug flag
The committers listed above are authorized under a signed CLA.
- :white_check_mark: login: jakobmoellersap / name: Jakob Möller (b24888594e9881faa6e085542aade0971a2e3124)
![linux-foundation-easycla[bot] avatar](https://avatars.githubusercontent.com/in/17893?v=4 "Published by a pub.dev verified publisher"){kind=small}
Hi @jakobmoellersap. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Welcome @jakobmoellersap!
It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Checked both failing tests and they seem to be timeout related, can I just rerun them?
golanci-lint still failing with exit 137
Exit code 137 is triggered when a pod or a container within your Kubernetes environment exceeds the amount of memory that they’re assigned
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: camilamacedo86, everettraven, jakobmoellersap
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [camilamacedo86]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@everettraven I checked your GH Actions and I think we cannot simply increase the memory limit through a setting as can be observed in https://github.com/golangci/golangci-lint-action#how-to-use, since it is a machine-limitation in the action. The only way I know to circuvment this is to adjust the GC as can be seen in https://golangci-lint.run/usage/performance/#memory-usage to increase Garbage Collection Cycles. This reduces memory footprint at the cost of heavily increased lint runtime (may not be favorable for us)
What do you I think I can do here to make this PR go in @camilamacedo86 @everettraven ?
Heavy Memory Usage is actually pretty common in golang-ci, I wonder how other projects go about it?
@jakobmoellersap I think modifying that GOGC environment variable to trigger garbage collection more frequently would suffice. Looking at the performance link you sent, it seems like setting the GOGC environment variable to a value of 20 would save ~1GB of memory and only increase execution time by ~11 seconds. I think that this is a relatively small tradeoff to decrease the memory consumption of the linter.
@camilamacedo86 WDYT?
@jakobmoellersap and @everettraven,
I think we need to try to upgrade the lint version to the latest. It seems a bug. could you open a PR for that?
@camilamacedo86 i can take a look at it. Seems to be failing on a couple other PRs that I have seen as well.
I'll create an issue for it and assign myself.
Blocked by https://github.com/kubernetes-sigs/kubebuilder/issues/2878