kubebuilder icon indicating copy to clipboard operation
kubebuilder copied to clipboard

:seedling: (phase 2 plugins): add simple external plugin to testdata

Open everettraven opened this issue 3 years ago • 5 comments
trafficstars

Description of the change

Add a new project to the testdata/ directory that is a very simple Phase 2 Plugin written in Go.

The implementation also includes comments that could be helpful for those attempting to write their own Phase 2 Plugins.

Motivation for the change

Create a sample Phase 2 Plugin that can be used to help with e2e testing the Phase 2 Plugins implementation.

everettraven avatar Jul 07 '22 18:07 everettraven

/hold I don't want this to merge until there has been more discussion on this change. I feel it may need some more work.

/cc @rashmigottipati @camilamacedo86

everettraven avatar Jul 07 '22 18:07 everettraven

/retest

everettraven avatar Jul 08 '22 16:07 everettraven

@camilamacedo86 @rashmigottipati Would you mind reviewing this again when you have some time? Thanks!

everettraven avatar Jul 18 '22 13:07 everettraven

Just wanted to post an update: I haven't had time to work on this recently due to other priority work on other projects. I am still planning to address all the review comments when I have some more time. Thanks!

everettraven avatar Aug 01 '22 18:08 everettraven

/retest

everettraven avatar Aug 19 '22 18:08 everettraven

/unhold

everettraven avatar Aug 26 '22 13:08 everettraven

/cc @jmrodri

everettraven avatar Aug 26 '22 13:08 everettraven

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: camilamacedo86, everettraven

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 29 '22 17:08 k8s-ci-robot