kubebuilder icon indicating copy to clipboard operation
kubebuilder copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

scaffolds hub and spoke interfaces for conversion webhooks.

Open camilamacedo86 opened this issue 3 years ago • 18 comments
trafficstars

What do you want to happen?

scaffolds hub and spoke interfaces for conversion webhooks. With this change, users can either specify --conversion flag and implement the interface on their own, or specify --hub and --spoke versions which will scaffold the skeleton code for both the interfaces.

Follow up/finish the work which started : https://github.com/kubernetes-sigs/kubebuilder/pull/2084

Extra Labels

No response

camilamacedo86 avatar Apr 02 '22 09:04 camilamacedo86

@camilamacedo86 What do we need to do here?

Do we need to:

  • Open a new PR with the changes done in https://github.com/kubernetes-sigs/kubebuilder/pull/2084
  • Work on the suggested changes mentioned in the PR review
  • Rebase the PR

?

NikhilSharmaWe avatar May 03 '22 11:05 NikhilSharmaWe

@camilamacedo86 Could you please take a look at my previous comment.

NikhilSharmaWe avatar May 10 '22 17:05 NikhilSharmaWe

Sure. Please, feel free to work on this one.

camilamacedo86 avatar May 11 '22 00:05 camilamacedo86

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 09 '22 00:08 k8s-triage-robot

/assign I can take a look into it.

laxmikantbpandhare avatar Aug 12 '22 15:08 laxmikantbpandhare

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Sep 11 '22 15:09 k8s-triage-robot

Yes, the goal of this task is to finalize the implementation done in the https://github.com/kubernetes-sigs/kubebuilder/pull/2084. So, you can get the changes made and address the comments.

IN this way, this one seems a good fit for the good first issue.

camilamacedo86 avatar Sep 12 '22 06:09 camilamacedo86

/assign

26tanishabanik avatar Sep 12 '22 08:09 26tanishabanik

@camilamacedo86 Is it already done? If not, I'd like to work on this!

momom-i avatar Oct 28 '22 16:10 momom-i

Hi @momom-i.

It is not. Please, feel free to work on this one. Your collaboration is very welcome.

I do not think that @26tanishabanik has been work on this. @26tanishabanik if you are doing it please, let us know.

Thx.

camilamacedo86 avatar Oct 28 '22 17:10 camilamacedo86

I don't think it's still resolved I would like to work on this now

/assign

ashutosh887 avatar Feb 26 '23 09:02 ashutosh887

@ashutosh887 I’m working on this now. /assign

momom-i avatar Feb 26 '23 09:02 momom-i

Sure @momom-i Please let me know if you need any help

ashutosh887 avatar Feb 26 '23 11:02 ashutosh887

Let me work on this @camilamacedo86 if @momom-i is unable to resolve

ashutosh887 avatar Mar 12 '23 21:03 ashutosh887

/assign

lauchokyip avatar May 14 '23 21:05 lauchokyip

/assign

momom-i avatar May 15 '23 01:05 momom-i

For anyone who is interested in working on this PR, IMHO, I do not think it's a good-first-issue. It requires good amount of knowledge for Go, cli and Kubernetes Webhook. You would also need to read the design proposals to come up with the best practice. Simply copy and paste the OP's PR will not work.

Estimated time from understanding to coding to open an PR and to get it merged would require at least a month of effort

lauchokyip avatar May 15 '23 03:05 lauchokyip

This issue has not been updated in over 1 year, and should be re-triaged.

You can:

  • Confirm that this issue is still relevant with /triage accepted (org members only)
  • Close this issue with /close

For more details on the triage process, see https://www.kubernetes.dev/docs/guide/issue-triage/

/remove-triage accepted

k8s-triage-robot avatar May 14 '24 03:05 k8s-triage-robot