kubebuilder icon indicating copy to clipboard operation
kubebuilder copied to clipboard

:sparkles: New plugin for config-gen as alpha.

Open Kavinjsir opened this issue 3 years ago • 8 comments
trafficstars

In respect to #issue2501, moving the package of config-gen from pkg/cli/alpha towards pkg/plugins.

Kavinjsir avatar Mar 14 '22 19:03 Kavinjsir

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: Kavinjsir / name: TianYi(Tony) (469c3d3f8063c019c7500b4e9d6ac323557a5681, 4db93a56a7b3bc5a720c0f2b11e68e03261f7d5d)

Welcome @Kavinjsir!

It looks like this is your first PR to kubernetes-sigs/kubebuilder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/kubebuilder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Mar 14 '22 19:03 k8s-ci-robot

Hi @Kavinjsir. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Mar 14 '22 19:03 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Kavinjsir To complete the pull request process, please assign pwittrock after the PR has been reviewed. You can assign the PR to them by writing /assign @pwittrock in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Mar 14 '22 19:03 k8s-ci-robot

/ok-to-test

camilamacedo86 avatar Mar 15 '22 11:03 camilamacedo86

@pwittrock could you give a hand on this one?

camilamacedo86 avatar Apr 02 '22 12:04 camilamacedo86

@Kavinjsir: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar May 13 '22 23:05 k8s-ci-robot

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 12 '22 00:08 k8s-triage-robot

@Kavinjsir,

I spoke with its author and he is ok with us deleting or moving config-gen from the project (looking for maintainability since this option does not seems that won atraction from the users). We will need to discuss the possibilities in the community meetings.

However, I understand that with your help we came to the conclusion that we cannot easily move this implementation to a plugin since we need to generate/execute the config-gen to do the actions.

In this way, I think we can close this PR and if we need we can re-open it. Feel free to re-open it if you see that it fits.

camilamacedo86 avatar Sep 05 '22 19:09 camilamacedo86