kubebuilder
kubebuilder copied to clipboard
Remove the word "whitelist" from our codebase
- https://github.com/kubernetes-sigs/kubebuilder/blob/38343942a397a02559bfdd46f3d31257d1561f98/pkg/cli/cli.go#L279
- https://github.com/kubernetes-sigs/kubebuilder/blob/master/docs/book/src/reference/admission-webhook.md "pod image whitelisting"
/wg naming /kind cleanup
Not get this one. Why we need to remove from the docs as well? What name you suggest for fs.ParseErrorsWhitelist
?
Allowlist/Denylist is the combination that has been chosen within the naming workgroup
/cc @justaugustus
Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale
.
Stale issues rot after an additional 30d of inactivity and eventually close.
If this issue is safe to close now please do so with /close
.
Send feedback to sig-testing, kubernetes/test-infra and/or fejta. /lifecycle stale
/lifecycle frozen
In this case, we cannot rename it. It is from the lib/dep. See: https://github.com/spf13/pflag/blob/master/flag.go#L128
- The issue raised in the project is : https://github.com/spf13/pflag/issues/294
- The PR to push it in the dep is: https://github.com/spf13/pflag/pull/295
Hello, camilla can you please add this link in your comment as well.
Note that kubebuilder source code not use Whitelist
term. The only place where it can be found is the usage of the method ParseErrorsWhitelist from spf13/pflag. When it be changed in the lib we will also automatically change it in Kubebuilder code when a bump be made. See: https://github.com/spf13/pflag/pull/261
Therefore, I am closing this one as done. If you have any objections, please feel free to re-open this one.