kubebuilder-declarative-pattern icon indicating copy to clipboard operation
kubebuilder-declarative-pattern copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

add x-kubernetes-preserve-unknown-fields to patches in CRD

Open atoato88 opened this issue 3 years ago • 2 comments

What this PR does / why we need it: This PR add x-kubernetes-preserve-unknown-fields: true to patches key about CRD implementing Patchable interface. This PR use markers in kubebuilder for that. Declarative CR will preserve any structures on patches key by this update.

Which issue(s) this PR fixes: Fixes #236

Special notes for your reviewer: NONE

Additional documentation: NONE

atoato88 avatar Aug 25 '22 06:08 atoato88

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: atoato88

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 25 '22 06:08 k8s-ci-robot

/assign @justinsb

atoato88 avatar Aug 29 '22 20:08 atoato88

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Nov 27 '22 20:11 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Dec 27 '22 21:12 k8s-triage-robot

/close It's pretty old PR so I close this.

atoato88 avatar Jan 18 '23 05:01 atoato88

@atoato88: Closed this PR.

In response to this:

/close It's pretty old PR so I close this.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 18 '23 05:01 k8s-ci-robot