kubebuilder-declarative-pattern

kubebuilder-declarative-pattern copied to clipboard

question: How to handle cluster scoped resources?

1

Currently cluster scoped resources can be created, but they're not removed when the declarative object is deleted because no ownerref. Is it expected that user should remove them manually?

killwing

Add unit test for direct applier

7

**What this PR does / why we need it**: This PR adds unit tests for direct applier in `direct.go`. `direct.go` doesn't have tests as far, we should add tests for...

atoato88

Improvement: kustomize should support base/ and overlay/ model

6

The library already has the support for the kustomize but it has some limitations that It ONLY loads the folder that is specified in the `PackageName` variable and this made...

JeffLuoo

**What happened**: When my `Preflight` check fails, I get a panic in the `Reconciled` implementation that I'm using (`status.NewAggregator`). It panics on the `objs.Items` access. On a brief inspection, the...

fsommar

don't remove objects with ignore annotation when prune is enabled

10

**What this PR does / why we need it**: fix #209 **Special notes for your reviewer**: **Additional documentation**:

xuzhenglun

Update guestbook

6

justinsb

Cross namespace pruning is not working as intended

2

**What happened**: Using `WithApplyPrune` in the operator doesn't prune the objects in different namespaces. **What you expected to happen**: All objects in all namespaces with matching labels will be pruned....

JeffLuoo

We should start using versions

10

Per discussion in https://github.com/kubernetes-sigs/kubebuilder-declarative-pattern/pull/169 we should probably have versioning in our library and maintain a release branch. * This should make the library a little easier to consume * By...

justinsb

pruning and resource ignore annotation is conflict

3

**What happened**: 1. Controller is enabled `prune`, so that resources can be deleted automatically after they are not in manifests. 2. After annotating a resource with `addons.k8s.io/ignore=true`, this resource will...

xuzhenglun

If an object transform fails, status is never updated

7

**What happened**: Consider a declarative reconciler set up like this: ```go func (r *MyReconciler) setupReconciler(mgr ctrl.Manager) (declarative.LabelMaker, error) { // ... return watchLabels, r.Reconciler.Init(mgr, &myapiv1.MyResource{}, // ... declarative.WithStatus(status.NewBasic(mgr.GetClient()), declarative.WithObjectTransform(myTransform), )...

tomasaschan