kubernetes-sigs
feat: allow spaces in plugin names in order to enable sub-commands
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: dhague Once this PR has been reviewed and has the lgtm label, please assign soltysh for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Welcome @dhague!
It looks like this is your first PR to kubernetes-sigs/krew 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/krew has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Wouldn't it suffice to just get rid of this line? https://github.com/kubernetes-sigs/krew/blob/f6138632e8d971fb8bbffa61568b7baf035ef267/internal/installation/install.go#L242
As long as the symlink in .krew/bin/ uses the original dashes kubectl should be able to interpret them as spaces right?
Wouldn't it suffice to just get rid of this line?
https://github.com/kubernetes-sigs/krew/blob/f6138632e8d971fb8bbffa61568b7baf035ef267/internal/installation/install.go#L242
As long as the symlink in
.krew/bin/uses the original dashes kubectl should be able to interpret them as spaces right?
That would be a breaking change, so no.
