krew-index icon indicating copy to clipboard operation
krew-index copied to clipboard

Add AWS RDS Proxy plugin

Open wojtekk opened this issue 10 months ago • 5 comments

Creates proxy to AWS RDS Cluster or Instance.

It uses the plugin net-forward under the hood.

Documentation and example: kubectl-aws-rds-proxy

image

wojtekk avatar Apr 21 '24 18:04 wojtekk

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:


Thanks for submitting your kubectl plugin to Krew! One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience! /kind new-plugin

ahmetb avatar Apr 21 '24 18:04 ahmetb

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: wojtekk Once this PR has been reviewed and has the lgtm label, please assign ahmetb for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Apr 21 '24 18:04 k8s-ci-robot

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: wojtekk / name: Wojciech Krawczyk (9e022b7a3b703cb26ce5e042618330287fc47e74, cae28d4f414c64616df5fec33625de359b2d234d)

Welcome @wojtekk!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Apr 21 '24 18:04 k8s-ci-robot

Hi, please refer to the naming document on the website. https://krew.sigs.k8s.io/docs/developer-guide/develop/naming-guide/ Typically we reserve vendor prefixes to plugins from vendors themselves.

ahmetb avatar Apr 22 '24 07:04 ahmetb

/close due to naming

ahmetb avatar Jun 27 '24 05:06 ahmetb

@ahmetb: Closed this PR.

In response to this:

/close due to naming

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

k8s-ci-robot avatar Jun 27 '24 05:06 k8s-ci-robot

You can still distribute your plugin via Krew using custom indexes: https://krew.sigs.k8s.io/docs/developer-guide/custom-indexes/ That way users can still install your plugin via Krew, but they'll be downloading the plugin manifest from your repository instead of krew-index.

ahmetb avatar Jun 27 '24 05:06 ahmetb