krew-index icon indicating copy to clipboard operation
krew-index copied to clipboard

Add dumpy plugin v0.1.0

Open larryTheSlap opened this issue 1 year ago • 6 comments

This plugin make capturing network traffic easy on containers for different kubernetes resources (deployments, replicasets, pods...). More details on : https://github.com/larryTheSlap/dumpy

larryTheSlap avatar Feb 12 '24 14:02 larryTheSlap

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: larryTheSlap (14dbc8a533ff8bc558da1fb5ba21e1c29ef10bbc)

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:


Thanks for submitting your kubectl plugin to Krew! One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience! /kind new-plugin

ahmetb avatar Feb 12 '24 14:02 ahmetb

Welcome @larryTheSlap!

It looks like this is your first PR to kubernetes-sigs/krew-index 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/krew-index has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Feb 12 '24 14:02 k8s-ci-robot

Do you mind explaining if this is a subset of sniff plugin that already exists? https://github.com/kubernetes-sigs/krew-index/blob/9449d397a524b1608588a824e97ca24800aafca1/plugins/sniff.yaml#L15

ahmetb avatar Feb 14 '24 05:02 ahmetb

I would not consider dumpy as a subset of ksniff but a different way to capture network traffic in Kubernetes, also ksniff is no longer maintained as of 2022.

larryTheSlap avatar Feb 14 '24 08:02 larryTheSlap

Hello @ahmetb, may i have some news about this PR please ?

larryTheSlap avatar Feb 26 '24 15:02 larryTheSlap

/lgtm /approve Thanks!

Also, please consider setting up Krew release automation which helps you skip manually making updates to your Krew manifests on each new version and send a pull request. It’s a GitHub workflow bot that can run every time you push a new tag. Those PRs are automatically approved.

ahmetb avatar Feb 26 '24 16:02 ahmetb

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ahmetb, larryTheSlap

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 26 '24 16:02 k8s-ci-robot