krew-index icon indicating copy to clipboard operation
krew-index copied to clipboard

Feat/add resource

Open bryant-rh opened this issue 3 years ago • 8 comments

This plugin Display Resource (CPU/Memory/PodCount) Usage and Request and Limit. The resource command allows you to see the resource consumption for nodes or pods. This command requires Metrics Server to be correctly configured and working on the server

https://github.com/bryant-rh/kubectl-resource-view

bryant-rh avatar Feb 17 '22 10:02 bryant-rh

:robot: Beep beep! I’m a robot speaking on behalf of @ahmetb. :robot:


Thanks for submitting your kubectl plugin to Krew! One of the krew-index maintainers will review it soon. Note that the reviews for new plugin submissions may take a few days.

In the meanwhile, here are a few tips to make your plugin manifest better:

  • Make sure your plugin follows the best practices.
  • Eliminate redundant wording form shortDescription (it should be max 50 characters).
  • Try to word wrap your description to 80-character lines (no usage examples, please).

Thanks for your patience! /kind new-plugin

ahmetb avatar Feb 17 '22 10:02 ahmetb

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: bryant-rh To complete the pull request process, please assign chriskim06 after the PR has been reviewed. You can assign the PR to them by writing /assign @chriskim06 in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Feb 17 '22 10:02 k8s-ci-robot

Have you had a chance to look at the other plug-ins that do similar things? It will be great if you can spell out the differences here.

ahmetb avatar Feb 17 '22 17:02 ahmetb

Have you had a chance to look at the other plug-ins that do similar things? It will be great if you can spell out the differences here.

This plugin adds resource usage metrics, similar to cpu request use and memory use。 When the percentage of cpu request and memory request is greater than 90, it will be marked in yellow, and if it is greater than 95, it will be marked in red。 and The statistics of gpu and npu resources will be added in the future。

image

image

bryant-rh avatar Feb 18 '22 02:02 bryant-rh

And can you more specifically comment on whether other plug-ins are able to do these things as well? Unless there is enough differentiation it's unlikely that we will except the submission.

ahmetb avatar Feb 18 '22 02:02 ahmetb

And can you more specifically comment on whether other plug-ins are able to do these things as well? Unless there is enough differentiation it's unlikely that we will except the submission.

The information of other plugins is scattered. For example, "kubectl top‘"can only view node or pod usage information, and ”kube-capacity“ can only view information such as request limit. This plugin integrates these information. and The statistics of gpu and npu resources will be added in the future。

bryant-rh avatar Feb 18 '22 02:02 bryant-rh

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Aug 15 '22 23:08 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Sep 15 '22 00:09 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-triage-robot avatar Oct 15 '22 01:10 k8s-triage-robot

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Reopen this PR with /reopen
  • Mark this PR as fresh with /remove-lifecycle rotten
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Oct 15 '22 01:10 k8s-ci-robot