kpng icon indicating copy to clipboard operation
kpng copied to clipboard

[WIP] #430 make e2e csv full report all backends target

Open emabota opened this issue 1 year ago • 13 comments

This PR is aimed at the issue #430. It focus, initially, on the implementation of the e2e_test in go. I decided to start by aiming at a program that will work on this conditions: ip_family=ipv4, backend=iptables, cluster_count=1

Studying the current test_e2e.sh script I identified the main functions required to have a working test_e2e.go program. And documented it in here. Please check the MILESTONES on the document, and let me know if there is something missing.

So basically my current approach is to implement each identified function, in go. On this PR I have implemented the first 5 functions: Info_error_exit, set_sysctl, set_host_networking_settings, add_to_path, setup_kind

@jayunit100 , @rajaskakodkar please comments. Let me know if this is the way to go.

emabota avatar Mar 19 '23 17:03 emabota

You have successfully added a new govulncheck configuration .github/workflows/security.yaml:govulncheck. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

You have successfully added a new gosec configuration .github/workflows/security.yaml:gosec. As part of the setup process, we have scanned this repository and found no existing alerts. In the future, you will see all code scanning alerts on the repository Security tab.

Thanks can you attach the cover sample output to a README.report.md file or something like that in this dir?

jayunit100 avatar Mar 20 '23 02:03 jayunit100

overall approach makes sense, once its done lets attach a readme w/ CSV results , how to generate them , etc...

jayunit100 avatar Mar 20 '23 13:03 jayunit100

I don't understand why the last commit is failing - https://github.com/kubernetes-sigs/kpng/actions/runs/4480600683/jobs/7876158548

emabota avatar Mar 21 '23 16:03 emabota

https://github.com/kubernetes/kubernetes/issues/108891 <-- the failure is a flake. just push a readme commit or something to rerun the testss

jayunit100 avatar Mar 23 '23 15:03 jayunit100

/approve

jayunit100 avatar Jun 21 '23 20:06 jayunit100

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: emabota, jayunit100

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Jun 21 '23 20:06 k8s-ci-robot

looks a good start, please run go fmt . before merging, we will need to enable lint on this folder as well.

knabben avatar Dec 07 '23 12:12 knabben

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle stale
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Mar 06 '24 13:03 k8s-triage-robot

/remove-lifecycle stale

emabota avatar Mar 06 '24 17:03 emabota