[understandability] make nft/ and iptables/ packages more similar

[jayunit100]

Both NFT And IPTAbles import the localsink package, of course, but the import different structs from it. To make it clear where their architecture is similar lets

• move the logic of iptables sink.go into register.go OR
• make the register.go in nft separated out into sink.go for the part that imports the "sigs.k8s.io/kpng/client/localsink/fullstate"
• make it so the different Sink implementations are easy to reason about
• Add logging to the OpItem and Send functions (these run on the backends... but they are called from the brain)

[k8s-ci-robot]

@jayunit100: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

• Why are we solving this issue?
• To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
• Does this issue have zero to low barrier of entry?
• How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

Both NFT And IPTAbles import the localsink package, of course, but the import different structs from it. To make it clear where their architecture is similar lets

• move the logic of iptables sink.go into register.go OR
• make the register.go in nft separated out into sink.go for the part that imports the "sigs.k8s.io/kpng/client/localsink/fullstate"

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[jayunit100]

this is not really a good first issue :) i think ill do it

[jayunit100]

/assign

[k8s-triage-robot]

The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

• After 90d of inactivity, lifecycle/stale is applied
• After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
• After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

• Mark this PR as fresh with /remove-lifecycle stale
• Close this PR with /close
• Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale