kind
kind copied to clipboard
kubernetes-sigs
Be more clear on the expected format of --wait option
This is just a very minor follow up on this pull request 3418.
kind create cluster --help does not explain what is expected format of --wait option. This is documented well in site/content/docs/user/quick-start.md but this simple change to command line help is going to save some time and confusion.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: radeksm Once this PR has been reviewed and has the lgtm label, please assign aojea for approval. For more information see the Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @radeksm. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
FWIW, this problem exists in kubectl as well, e.g. kubectl wait --help --timeout docs, these are go https://pkg.go.dev/time#Duration if we want to be more specific.
This change seems fine, but I prefer to align with kubectl where possible on the CLI flags and behaviors for consistency, maybe we need (or have already and can just reference?) a kubernetes.io docs page to cover these duration strings, they're used in other places in the project.
FWIW, this problem exists in kubectl as well, e.g.
kubectl wait --help--timeoutdocs, these are go https://pkg.go.dev/time#Duration if we want to be more specific.This change seems fine, but I prefer to align with
kubectlwhere possible on the CLI flags and behaviors for consistency, maybe we need (or have already and can just reference?) a kubernetes.io docs page to cover these duration strings, they're used in other places in the project.
@BenTheElder I will create new pull req to adjust in for kubectl so we can make it more clear and consistent.
Actually the same kind of inconsistency exists in kubectl on blow three subcommands too:
kubectl drain --timeout=...
kubectl wait --timeout=...
kubectl delete --timeout=...
1.24 seems to be permanently failing https://prow.k8s.io/pr-history/?org=kubernetes-sigs&repo=kind&pr=3419, keep retesting is not going to solve the problem ;)
1.24 seems to be permanently failing https://prow.k8s.io/pr-history/?org=kubernetes-sigs&repo=kind&pr=3419, keep retesting is not going to solve the problem ;)
Yeahhh but it seems to be not related to my change and I thought it's some CI problem with lack of resources. It was the same with pull-kind-e2e-kubernetes-1-25 which eventually passed. Sorry but I am not familiar with the CI.
@radeksm: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-kind-e2e-kubernetes-1-24 | 56db1281bc0666368896a5aabf24584c5eedb6dd | link | true | /test pull-kind-e2e-kubernetes-1-24 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.