kind
kind copied to clipboard
kubernetes-sigs
Shellcheck fixes
- upgrade shellcheck
- support host binary without docker if it's the correct version
- support podman instead of docker
- fix vagrant-helper
- upgrade gimmee
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: BenTheElder
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [BenTheElder]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
at current main, when calling make verify, I had this warning:
make verify
hack/make-rules/verify/all.sh
verifying lints ...
verifying generated ...
hack/make-rules/update/generated.sh
hack/make-rules/update/gofmt.sh
verifying shellcheck ...
shellcheck: timer_create: Resource temporarily unavailable
One or more verify checks failed! See output above...
make: *** [verify] Error 1
Using this PR, it fixed that issue:
make verify
hack/make-rules/verify/all.sh
verifying lints ...
verifying generated ...
hack/make-rules/update/generated.sh
hack/make-rules/update/gofmt.sh
verifying shellcheck ...
Using host shellcheck 0.8.0 binary.
All verify checks passed, congrats!
It runs on a Mac M1
Given that your output shows it using the host binary it may just be that requiring the same version you currently have installed fixed it and that this will still be broken when those skew.
I actually don't have kind binary on the host. I also tried setting the ulimit manually, and it doesn't fix the issue (using current main code / shellcheck 0.7.1)
I actually don't have kind binary on the host.
shellcheck binary, not kind. (See the logs / script logic)
I also tried setting the ulimit manually, and it doesn't fix the issue (using current main code / shellcheck 0.7.1)
To be clear: there are many limits, I'm talking about a limit inside the docker desktop VM. And not file handles.
hmm can't find how to force actions to run again and the logs are gone
rebase and push ?
rebase and push ?
: effort :, too many other things to do. prow I can just /retest or /test
@BenTheElder: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-kind-e2e-kubernetes-1-20 | f8cd7207e0594f154eb1843b1fe82844fcd08479 | link | true | /test pull-kind-e2e-kubernetes-1-20 |
| pull-kind-e2e-kubernetes-1-21 | f8cd7207e0594f154eb1843b1fe82844fcd08479 | link | true | /test pull-kind-e2e-kubernetes-1-21 |
| pull-kind-e2e-kubernetes | f8cd7207e0594f154eb1843b1fe82844fcd08479 | link | true | /test pull-kind-e2e-kubernetes |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.
actions failed with
ERROR: Got permission denied while trying to connect to the Docker daemon socket at unix:///var/run/docker.sock: Get "http://%2Fvar%2Frun%2Fdocker.sock/v1.24/info": dial unix /var/run/docker.sock: connect: permission denied
and the podman job with
ERROR: failed to create cluster: running kind with rootless provider requires setting systemd property "Delegate=yes", see https://kind.sigs.k8s.io/docs/user/rootless/
