kubernetes-sigs
cleanup: make the import order follow the best practice
Fixes #N/A
Description
make the import order follow the best practice. We should use gci to do lint checking
How was this change tested?
Nothing about logic changes. So we don't need to test.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Hi @jwcesign. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
cool! Maybe you want to update https://github.com/kubernetes-sigs/karpenter/blob/main/.golangci.yaml?
Sure
Pull Request Test Coverage Report for Build 10796120994
Details
- 0 of 0 changed or added relevant lines in 0 files are covered.
- No unchanged relevant lines lost coverage.
- Overall coverage increased (+0.04%) to 80.607%
| Totals | |
|---|---|
| Change from base Build 10729017085: | 0.04% |
| Covered Lines: | 8388 |
| Relevant Lines: | 10406 |
💛 - Coveralls
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: jwcesign, njtran
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [njtran]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment