jobset
jobset copied to clipboard
kubernetes-sigs
docs: small kep for DRA
What type of PR is this?
/kind feature /kind api-change
What this PR does / why we need it:
Small KEP for https://github.com/kubernetes-sigs/jobset/issues/762
Which issue(s) this PR fixes:
Adresses https://github.com/kubernetes-sigs/jobset/issues/762
Special notes for your reviewer:
Does this PR introduce a user-facing change?
n/a
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: acpana Once this PR has been reviewed and has the lgtm label, please assign kannon92 for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Welcome @acpana!
It looks like this is your first PR to kubernetes-sigs/jobset 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/jobset has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @acpana. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for kubernetes-sigs-jobset canceled.
| Name | Link |
|---|---|
| Latest commit | f187b38246ccf8e28939eced71b0673335d9b563 |
| Latest deploy log | https://app.netlify.com/projects/kubernetes-sigs-jobset/deploys/685df38551e8770008184686 |
![netlify[bot] avatar](https://avatars.githubusercontent.com/in/13473?v=4 "Published by a pub.dev verified publisher"){kind=small}
hey @kannon92 @andreyvelich are you the right folks to sign off on this? I think y'all had a fair amount of feedback here (in addition to john)
@acpana: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-jobset-test-e2e-main-1-30 | 47fd03539181141772597d5746e454a290ec34cd | link | true | /test pull-jobset-test-e2e-main-1-30 |
| pull-jobset-verify-main | f187b38246ccf8e28939eced71b0673335d9b563 | link | true | /test pull-jobset-verify-main |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.
I am having a hard time following DRA and this work.
Have you implemented this idea? It seems there is a lot of work called this out as a motivating use case. Is it actually possible to implement this with current DRA?
I'd love a POC and a demo to show that this works in reality before we commit to design/implementation.
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs.
This bot triages PRs according to the following rules:
- After 90d of inactivity,
lifecycle/staleis applied - After 30d of inactivity since
lifecycle/stalewas applied,lifecycle/rottenis applied - After 30d of inactivity since
lifecycle/rottenwas applied, the PR is closed
You can:
- Mark this PR as fresh with
/remove-lifecycle stale - Close this PR with
/close - Offer to help out with Issue Triage
Please send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale
I am wondering if we should close this. Our current thinking is to instead tie RC/RCT support to the Workload resource being developed as part of https://github.com/kubernetes/enhancements/issues/4671
@kannon92: Closed this PR.
In response to this:
+1 on that /close
Thank you for your work @acpana!
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.