jobset
jobset copied to clipboard
Add bash script to sync manifests from Helm chart to Kustomize
What type of PR is this?
/kind cleanup
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #820
Special notes for your reviewer:
Does this PR introduce a user-facing change?
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: ChenYi015 Once this PR has been reviewed and has the lgtm label, please assign ahg-g for approval. For more information see the Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Hi @ChenYi015. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Deploy Preview for kubernetes-sigs-jobset canceled.
| Name | Link |
|---|---|
| Latest commit | ecd4f1afcbc4f83a2740ec548493978f8248507b |
| Latest deploy log | https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/67dd387f3d8c7b0008ee9458 |
/ok-to-test
/ok-to-test
@ChenYi015 feel free to mark this ready if you want the CI to run?
I guess draft PRs do not run the CI.
I am starting to lean towards making helm as the source of truth, and use helm template to auto-generate a kubectl deployable manifest. wdyt?
PR needs rebase.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
@ChenYi015 this would be really great to have.
Do you have any cycles to spare on this?
@ChenYi015: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:
| Test name | Commit | Details | Required | Rerun command |
|---|---|---|---|---|
| pull-jobset-test-e2e-main-1-32 | ecd4f1afcbc4f83a2740ec548493978f8248507b | link | true | /test pull-jobset-test-e2e-main-1-32 |
| pull-jobset-test-e2e-main-1-30 | ecd4f1afcbc4f83a2740ec548493978f8248507b | link | true | /test pull-jobset-test-e2e-main-1-30 |
| pull-jobset-test-e2e-main-1-31 | ecd4f1afcbc4f83a2740ec548493978f8248507b | link | true | /test pull-jobset-test-e2e-main-1-31 |
| pull-jobset-test-e2e-main-1-33 | ecd4f1afcbc4f83a2740ec548493978f8248507b | link | true | /test pull-jobset-test-e2e-main-1-33 |
| pull-jobset-test-e2e-main-1-34 | ecd4f1afcbc4f83a2740ec548493978f8248507b | link | true | /test pull-jobset-test-e2e-main-1-34 |
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.