jobset icon indicating copy to clipboard operation
jobset copied to clipboard

add the unparam linter to golangci and fix those issues flagged

Open kannon92 opened this issue 1 year ago • 2 comments

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

add linter for unused parameters.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

kannon92 avatar Aug 09 '24 15:08 kannon92

Deploy Preview for kubernetes-sigs-jobset canceled.

Name Link
Latest commit c1e2aceb1ea25e74b64a18202f9ffe3b54b12ed6
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/66b95a7b4c578300086bc4e3

netlify[bot] avatar Aug 09 '24 15:08 netlify[bot]

/lgtm /approve

Thanks for adding this!

danielvegamyhre avatar Aug 12 '24 17:08 danielvegamyhre

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielvegamyhre, kannon92

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [danielvegamyhre]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Aug 12 '24 17:08 k8s-ci-robot