jobset icon indicating copy to clipboard operation
jobset copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

chore: use symbolic link instead of directory

Open googs1025 opened this issue 1 year ago • 8 comments

  • use symbolic link instead of directory to avoid examples inconsistencies

googs1025 avatar Jul 27 '24 08:07 googs1025

Deploy Preview for kubernetes-sigs-jobset canceled.

Name Link
Latest commit 9f9107a27a3c6eb58ee936a76a65b009286b4d47
Latest deploy log https://app.netlify.com/sites/kubernetes-sigs-jobset/deploys/66ed90ecff317d00081a3a94

netlify[bot] avatar Jul 27 '24 08:07 netlify[bot]

/hold When both PR https://github.com/kubernetes-sigs/jobset/pull/601 and PR https://github.com/kubernetes-sigs/jobset/pull/629 are merged, I will rebase again

googs1025 avatar Jul 27 '24 08:07 googs1025

Same as kueue project: https://github.com/kubernetes-sigs/kueue/blob/main/examples

googs1025 avatar Jul 27 '24 08:07 googs1025

/kind cleanup

googs1025 avatar Jul 27 '24 08:07 googs1025

Seems like this needs a rebase @googs1025

danielvegamyhre avatar Jul 30 '24 01:07 danielvegamyhre

After this PR https://github.com/kubernetes-sigs/jobset/pull/601 is merged, I will rebase it together

googs1025 avatar Jul 30 '24 08:07 googs1025

@googs1025 are you still working on this?

danielvegamyhre avatar Sep 08 '24 16:09 danielvegamyhre

@googs1025 are you still working on this?

Yes, but I want to wait until the PR https://github.com/kubernetes-sigs/jobset/pull/601 is merged before making the changes. This will prevent the PR https://github.com/kubernetes-sigs/jobset/pull/601 from needing to be rebased.

googs1025 avatar Sep 09 '24 01:09 googs1025

Already ready for next !

googs1025 avatar Sep 20 '24 15:09 googs1025

/unhold

googs1025 avatar Sep 22 '24 07:09 googs1025

@googs1025 why did you delete some of the examples, is that an accident? You may need to rebase

danielvegamyhre avatar Sep 23 '24 17:09 danielvegamyhre

main: https://github.com/kubernetes-sigs/jobset/tree/main/site/static/examples https://github.com/googs1025/jobset/tree/remove-example/site/static/examples

I checked and found that site/static/examples already has these examples. So those in examples/ can be deleted directly. This way we don’t have to maintain two sets of examples, which can easily increase example inconsistencies.

googs1025 avatar Sep 24 '24 01:09 googs1025

@danielvegamyhre

googs1025 avatar Sep 26 '24 00:09 googs1025

/lgtm /approve

danielvegamyhre avatar Sep 27 '24 02:09 danielvegamyhre

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: danielvegamyhre, googs1025

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • ~~OWNERS~~ [danielvegamyhre]

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 27 '24 02:09 k8s-ci-robot