ingress2gateway icon indicating copy to clipboard operation
ingress2gateway copied to clipboard

Add translation for GKE Custom health check

Open sawsa307 opened this issue 1 year ago • 5 comments

What type of PR is this? /kind feature

What this PR does / why we need it: Adding a new feature for GKE Ingress and Gateway conversion.

Which issue(s) this PR fixes: Adding more feature for #87.

Does this PR introduce a user-facing change?:

Ingress2gateway now supports translating Custom Health Check on GKE Ingress to HealthCheckPolicy on GKE Gateway.

sawsa307 avatar Sep 16 '24 21:09 sawsa307

/assign @LiorLieberman /assign @spencerhance

sawsa307 avatar Sep 16 '24 22:09 sawsa307

/hold Wait until #191 and #193 get merged.

sawsa307 avatar Sep 16 '24 22:09 sawsa307

/unhold

sawsa307 avatar Sep 17 '24 20:09 sawsa307

/retest

sawsa307 avatar Sep 17 '24 20:09 sawsa307

Hi, just checking in, anything I can do to help with this?

Ca this be reviewed by someone from GKE? /cc @spencerhance @robscott

LiorLieberman avatar Sep 26 '24 07:09 LiorLieberman

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: robscott, sawsa307

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 27 '24 23:09 k8s-ci-robot

/lgtm /hold for @robscott to check the changes he requested are in

LiorLieberman avatar Sep 30 '24 08:09 LiorLieberman

Thanks @sawsa307!

/lgtm /hold cancel

robscott avatar Sep 30 '24 17:09 robscott

/lgtm

robscott avatar Sep 30 '24 18:09 robscott