ingress2gateway
ingress2gateway copied to clipboard
kubernetes-sigs
added notifications for kong provider
What type of PR is this?
/kind feature
What this PR does / why we need it: This PR adds notifications for conversion of Kong provider
Which issue(s) this PR fixes:
This pull request addresses part of the issue described in #131
Does this PR introduce a user-facing change?:
Added notifications for Kong
/cc @mlavacca @LiorLieberman
Hi @Devaansh-Kumar. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.
Work on gateway merging, plugin feature parser and successful conversions is pending due to some clarifications required
Thanks for this PR, @Devaansh-Kumar!
My general feedback is that we definitely need tests for this PR. You could improve the already existing tests we have in the Kong provider by adding checks on the notifications created. WDYT?
We already have tests for notifications package. I suppose that should be enough.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: Devaansh-Kumar, mlavacca
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~OWNERS~~ [mlavacca]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment