Added IngressClass objects support #117

[Varun1300211]

What type of PR is this? This pull request implements IngressClass support.

Add one of the following kinds: /kind feature

What this PR does / why we need it: It retrieves the default IngressClass based on its API group (networking.k8s.io) and a dedicated annotation (ingressclass.kubernetes.io/is-default-class). If no explicit IngressClass is specified in the Ingress object or via annotation, the default class is used for resource processing.

Which issue(s) this PR fixes:

Fixes #117

Does this PR introduce a user-facing change?:

Please do let me know if it was done in the correct way.

[linux-foundation-easycla[bot]]

The committers listed above are authorized under a signed CLA.

• :white_check_mark: login: Varun1300211 / name: Varun Kumar Gupta (6293f14b68407e2e93a233e1f744a19d30b4dde2, 5b80862d241e80ed5d86ca762c9de195aaff27a1)

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Varun1300211 Once this PR has been reviewed and has the lgtm label, please assign bowei for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

[k8s-ci-robot]

Welcome @Varun1300211!

It looks like this is your first PR to kubernetes-sigs/ingress2gateway 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/ingress2gateway has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

[k8s-ci-robot]

Hi @Varun1300211. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

[Varun1300211]

/easycla

[LiorLieberman]

/ok-to-test

[LiorLieberman]

Thanks @Varun1300211 !

I will probably look at it tomorrow. In the meantime, can you:

1. add a release_note block in the PR description (it should be added by default every PR but looks like you deleted it)
2. Retitle the PR to reflect exactly the change your are adding
3. Why did you update go mod (probably you run go mod tidy)? I dont think thats needed so if you can revert it it will be awesome.

Thanks! /hold

[Varun1300211]

Done all the changes requested by you @LiorLieberman, please let me know if anything else is required.

[k8s-ci-robot]

@Varun1300211: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Required	Rerun command
pull-ingress2gateway-verify	5b80862d241e80ed5d86ca762c9de195aaff27a1	link	true	/test pull-ingress2gateway-verify
pull-ingress2gateway-test	5b80862d241e80ed5d86ca762c9de195aaff27a1	link	true	/test pull-ingress2gateway-test

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

[Varun1300211]

Hi @levikobi, I made the changes suggested by you. Please take a look.

[LiorLieberman]

@Varun1300211 Just checking in, please let us know if you need any help with moving this forward

[LiorLieberman]

@Varun1300211 a friendly ping, are you still planning to work on this?