ingress2gateway icon indicating copy to clipboard operation
ingress2gateway copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Add support for `IngressClass` objects

Open levikobi opened this issue 1 year ago • 19 comments

What would you like to be added: Add support for reading and taking into account IngressClass objects.

Why this is needed: If users do not specify ingressClassName, we need to understand the default IngressClass that should be used for the conversion.

levikobi avatar Jan 03 '24 19:01 levikobi

/help

levikobi avatar Jan 04 '24 07:01 levikobi

@levikobi: This request has been marked as needing help from a contributor.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-help command.

In response to this:

/help

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Jan 04 '24 07:01 k8s-ci-robot

/good-first-issue

mlavacca avatar Feb 01 '24 09:02 mlavacca

@mlavacca: This request has been marked as suitable for new contributors.

Guidelines

Please ensure that the issue body includes answers to the following questions:

  • Why are we solving this issue?
  • To address this issue, are there any code changes? If there are code changes, what needs to be done in the code and what places can the assignee treat as reference points?
  • Does this issue have zero to low barrier of entry?
  • How can the assignee reach out to you for help?

For more details on the requirements of such an issue, please see here and ensure that they are met.

If this request no longer meets these requirements, the label can be removed by commenting with the /remove-good-first-issue command.

In response to this:

/good-first-issue

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 01 '24 09:02 k8s-ci-robot

/assign

akagami-harsh avatar Feb 09 '24 12:02 akagami-harsh

I have created a PR for the same. Kindly review it.

Varun1300211 avatar Feb 13 '24 18:02 Varun1300211

I just now noticed that @akagami-harsh asked to work on this issue first. @akagami-harsh are you still interested in working on it?

levikobi avatar Feb 14 '24 06:02 levikobi

@levikobi yes i am interested. i was busy with other things, but now i am free

akagami-harsh avatar Feb 14 '24 06:02 akagami-harsh

Since there's already an open PR for this issue, should I create a new one?

akagami-harsh avatar Feb 14 '24 09:02 akagami-harsh

Hi @akagami-harsh, no. There is already a PR @Varun1300211 opened.

Please check out other issues like https://github.com/kubernetes-sigs/ingress2gateway/issues/81 if you are still up for contributing. We would love to have you.

@Varun1300211 While we appreciate you quickly made a PR and sent for review, next time, please kindly try to confirm with the current assignee if he is working on it before proceeding with a PR

LiorLieberman avatar Feb 14 '24 09:02 LiorLieberman

Apologies @akagami-harsh, I am still very new to the open source. Never seen you were already assigned to it before. Hope you understand.

Sure @LiorLieberman will keep it in mind from the next time onwards.

Varun1300211 avatar Feb 14 '24 10:02 Varun1300211

No worries at all, @Varun1300211! It happens, and I appreciate you being open to the feedback. Thanks for letting me know, @LiorLieberman . I'll take a look at issue #81.

akagami-harsh avatar Feb 14 '24 12:02 akagami-harsh

hi @akagami-harsh, are you still working on it, I would like to give it a try. 😊 /assign

ipsum-0320 avatar Apr 02 '24 13:04 ipsum-0320

@ipsum-0320, please notice @Varun1300211 is already assigned to this issue.

@Varun1300211, are you still working on it?

mlavacca avatar Apr 02 '24 15:04 mlavacca

@ipsum-0320, please notice @Varun1300211 is already assigned to this issue.

@Varun1300211, are you still working on it?

okok, I will wait until @Varun1300211 replies before taking the next step 😊

ipsum-0320 avatar Apr 03 '24 03:04 ipsum-0320

/assign

VasuDevrani avatar May 13 '24 11:05 VasuDevrani

@levikobi @LiorLieberman If neither the ingressClassName field nor the kubernetes.io/ingress.class annotation is set on the Ingress, the tool skips processing that Ingress, resulting in no Gateway API resources?

VasuDevrani avatar May 13 '24 17:05 VasuDevrani

@levikobi @LiorLieberman If neither the ingressClassName field nor the kubernetes.io/ingress.class annotation is set on the Ingress, the tool skips processing that Ingress, resulting in no Gateway API resources?

At the time I opened this issue this was correct @VasuDevrani, I think this still holds true though. The purpose of this issue is to add support for reading the ingressClasses, one of them should be the default. Then we will be able to convert ingresses without the field or annotation being specified

levikobi avatar May 15 '24 05:05 levikobi

Hi @VasuDevrani, any news on this issue? If you need some help, please let us know :)

mlavacca avatar Jun 13 '24 08:06 mlavacca