image-builder
image-builder copied to clipboard
kubernetes-sigs
Added Ubuntu 22.04 builds for AWS and GCP
What this PR does / why we need it: Adds build targets for Ubuntu 22.04 on AWS and GCP
Which issue(s) this PR fixes (optional, in fixes #
Additional context
Hi @AverageMarcus. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: AverageMarcus
Once this PR has been reviewed and has the lgtm label, please assign vincepri for approval by writing /assign @vincepri in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
@MarcusNoble I tried running a 22.04 build on AWS and ran into this issue
==> ubuntu-22.04: Launching a source AWS instance...
==> ubuntu-22.04: Adding tags to source instance
ubuntu-22.04: Adding tag: "Name": "Packer Builder"
ubuntu-22.04: Instance ID: i-0b8be6898bed5161d
==> ubuntu-22.04: Waiting for instance (i-0b8be6898bed5161d) to become ready...
==> ubuntu-22.04: Using ssh communicator to connect: 44.198.59.225
==> ubuntu-22.04: Waiting for SSH to become available...
==> ubuntu-22.04: Error waiting for SSH: Packer experienced an authentication error when trying to connect via SSH. This can happen if your username/password are wrong. You may want to double-check your credentials as part of your debugging process. original error: ssh: handshake failed: ssh: unable to authenticate, attempted methods [none publickey], no supported methods remain
==> ubuntu-22.04: Terminating the source AWS instance...
Builds work fine with 20.04. So I'm thinking there's some version issues in 22.04? I'm using packer 1.8.4. Did you see similar issues in your testing?
I did initially. I forget exactly what the fix was. Are you using the latest version of the image-builder container image?
We've been building 22.04 AMIs for a while now, here's the override values we're using for it: https://github.com/giantswarm/capi-image-builder/blob/d97cc5dec3421fd5959a2f64197f0417c937f6d7/helm/capi-image-builder/templates/pipelines/capa.yaml#LL67C17-L67C17
@AverageMarcus Sorry for the delayed reply, I was using packer 1.7.2 before. I upgraded to 1.8.4 and things seem to be progressing.
Thanks for adding this @AverageMarcus I'm able to Ubuntu 22.04 AMIs. Can you pls squash your commits and I'll get this merged.
[APPROVALNOTIFIER] This PR is APPROVED
This pull-request has been approved by: AverageMarcus, kkeshavamurthy
The full list of commands accepted by this bot can be found here.
The pull request process is described here
- ~~images/capi/OWNERS~~ [kkeshavamurthy]
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment