image-builder icon indicating copy to clipboard operation
image-builder copied to clipboard

Add cluster-api-nutanix-maintainers

Open vnephologist opened this issue 3 years ago • 5 comments

What this PR does / why we need it:

This PR adds cluster-api-nutanix-maintainers owners alias with appropriate members to approve and maintain Nutanix image components in /images/capi/nutanix.

There is a dependency on this issue to have deepakm-nutanix added as a community member.

vnephologist avatar Sep 27 '22 15:09 vnephologist

CLA Signed

The committers listed above are authorized under a signed CLA.

  • :white_check_mark: login: vnephologist / name: Andy Daniel (b23c82412048af0056ba7b5a09b541dc79aa485c)

Welcome @vnephologist!

It looks like this is your first PR to kubernetes-sigs/image-builder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-sigs/image-builder has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. :smiley:

k8s-ci-robot avatar Sep 27 '22 15:09 k8s-ci-robot

Hi @vnephologist. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Sep 27 '22 15:09 k8s-ci-robot

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: vnephologist Once this PR has been reviewed and has the lgtm label, please assign cecilerobertmichon for approval by writing /assign @cecilerobertmichon in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 27 '22 15:09 k8s-ci-robot

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes-sigs org. You can then trigger verification by writing /verify-owners in a comment.

  • deepakm-ntnx
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

k8s-ci-robot avatar Sep 27 '22 15:09 k8s-ci-robot

/verify-owners

CecileRobertMichon avatar Nov 09 '22 23:11 CecileRobertMichon

/ok-to-test

CecileRobertMichon avatar Nov 09 '22 23:11 CecileRobertMichon

/verify-owners

kkeshavamurthy avatar Nov 21 '22 21:11 kkeshavamurthy

I wonder why the invalid owners file label is still on. @CecileRobertMichon @jsturtevant any ideas?

kkeshavamurthy avatar Dec 14 '22 17:12 kkeshavamurthy

It looks like @deepakm-ntnx isn't apart of the kubernetes-sigs org?

/verify-owners

jsturtevant avatar Dec 22 '22 14:12 jsturtevant

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes-sigs org. You can then trigger verification by writing /verify-owners in a comment.

  • deepakm-ntnx
    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.

k8s-ci-robot avatar Dec 22 '22 14:12 k8s-ci-robot