image-builder
image-builder copied to clipboard
kubernetes-sigs
debian kernel params console
What this PR does / why we need it: When runnig a debian base image at kubevirt is not possible to run virtctl console, this change add the missing kernel params to allow that.
Additional context
Depends on:
- #980
Welcome @qinqon!
It looks like this is your first PR to kubernetes-sigs/image-builder 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.
You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.
You can also check if kubernetes-sigs/image-builder has its own contribution guidelines.
You may want to refer to our testing guide if you run into trouble with your tests not passing.
If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!
Thank you, and welcome to Kubernetes. :smiley:
Hi @qinqon. Thanks for your PR.
I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.
Once the patch is verified, the new status will be reflected by the ok-to-test label.
I understand the commands that are listed here.
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.
Removed the dependency on guest-agent since this PR does not dpeend on that.
[APPROVALNOTIFIER] This PR is NOT APPROVED
This pull-request has been approved by: qinqon, usrbinkat
Once this PR has been reviewed and has the lgtm label, please assign enxebre for approval by writing /assign @enxebre in a comment. For more information see:The Kubernetes Code Review Process.
The full list of commands accepted by this bot can be found here.
Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment
Will https://github.com/kubernetes-sigs/image-builder/pull/998 fix the same?
/cc @CecileRobertMichon
Pinging @CecileRobertMichon as a cluster-api-maintainers human for /approve , feel free to kick it to another approver.
I chose from from https://github.com/kubernetes-sigs/image-builder/blob/master/OWNERS_ALIASES#L32-L36
Do we still need this PR with https://github.com/kubernetes-sigs/image-builder/pull/998 merged?
