image-builder icon indicating copy to clipboard operation
image-builder copied to clipboard

Published 20 hours ago • verified publisher icon kubernetes-sigs

Added qemu guest agent

Open isaacdorfman opened this issue 2 years ago • 5 comments

As discussed in: https://github.com/kubernetes-sigs/image-builder/pull/847

I moved the adding of qemu-guest-agent into the image into a separate PR.

This branch is forked from the one in the previous PR so should only be merged after it.

isaacdorfman avatar Sep 20 '22 12:09 isaacdorfman

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: isaacdorfman Once this PR has been reviewed and has the lgtm label, please assign fabriziopandini for approval by writing /assign @fabriziopandini in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment Approvers can cancel approval by writing /approve cancel in a comment

k8s-ci-robot avatar Sep 20 '22 12:09 k8s-ci-robot

@davidvossel @seanschneeweiss FYI

isaacdorfman avatar Sep 20 '22 12:09 isaacdorfman

I'll copy/paste the same comment to this issue to have it within this disussion.

We asked Canonical on whether to use the qemu-guest-agent or not. There is no clear recommendation. It is a decision based on every individual use case.

Qemu Guest Agent [1] is used by some of the Canonical customers and in general it is supported by the KVM (and OpenStack installations with virtualization based on KVM). Unfortunately there is no official Canonical documentation that provides pros and cons to make our client decision easier. Following are some items to take into consideration when using the guest agent:

  1. it allows for file system access from the host to a VM
  2. it allows for changing user's password on a VM, including root password
  3. it allows for read/write file access within a VM
  4. it provides another layer of connectivity between a VM and host and in some particular use cases this might be beneficial, ie. quiescence filesystem prior to snapshot in order to have consistent data

However it should be conscious, justified decision of a cloud user/operator to start using the agent as it exposed VM data to some extent.

[1] https://qemu-project.gitlab.io/qemu/interop/qemu-ga.html

For us personally, we won't be using the qemu-guest-agent. I'd recommend opt-in rather then opt-out.

Sean Schneeweiss [email protected], Mercedes-Benz Tech Innovation GmbH, Provider Information

seanschneeweiss avatar Sep 25 '22 15:09 seanschneeweiss

/retest

qinqon avatar Sep 27 '22 07:09 qinqon

Seems like none of the providers (vsphere, aws, azure, gcp, openstack, etc) needs the qemu-guest-agent.

kkeshavamurthy avatar Oct 11 '22 17:10 kkeshavamurthy

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue or PR as fresh with /remove-lifecycle stale
  • Mark this issue or PR as rotten with /lifecycle rotten
  • Close this issue or PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot avatar Jan 09 '23 18:01 k8s-triage-robot

The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs.

This bot triages PRs according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the PR is closed

You can:

  • Mark this PR as fresh with /remove-lifecycle rotten
  • Close this PR with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot avatar Feb 08 '23 18:02 k8s-triage-robot

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot avatar Feb 09 '23 23:02 k8s-ci-robot

I'm closing this PR since there has not been any updates in a long time. Please re-open when needed.

kkeshavamurthy avatar Feb 14 '23 08:02 kkeshavamurthy